Jump to content

General Refactor


Recommended Posts

Some of my servers are beginning to require HTTP 1.1. However LabVIEW's HTTP API doesn't appear to support HTTP 1.1. I think the JKI rest API should be refactored so that functions can be extended. Right now, the meaty functions like Get, Put, etc all call into a single vi under the hood which makes extension very difficult. Further, there are a number of helper vis that are private and would need to be reimplemented. (all of the details are captured in this bug report: https://github.com/JKISoftware/JKI-HTTP-REST-Client/issues/24).

I propose the API be refactored under the hood so that Get, Put, etc can be overridden and extended. Thoughts?
 

Link to comment
Share on other sites

Sounds good to me!

I tried getting the code but I don't see any changes since Jan 2021 (https://github.com/jyoung8711/JKI-HTTP-REST-Client/tree/jyoung_interface). Am I looking in the wrong place? I was hoping to see the solution so I could evaluate the solution as well. The latest changes I see are updates to the Readme. And the last merge request from jyoung was Jan 2021. 

AND I'm not the best at git so i'm probably missing the proposed change. Is there a way I could see the pull request that solves the problem I've mentioned?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...
 Share

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.