Chris Cilino Posted October 8, 2022 Report Share Posted October 8, 2022 Some of my servers are beginning to require HTTP 1.1. However LabVIEW's HTTP API doesn't appear to support HTTP 1.1. I think the JKI rest API should be refactored so that functions can be extended. Right now, the meaty functions like Get, Put, etc all call into a single vi under the hood which makes extension very difficult. Further, there are a number of helper vis that are private and would need to be reimplemented. (all of the details are captured in this bug report: https://github.com/JKISoftware/JKI-HTTP-REST-Client/issues/24). I propose the API be refactored under the hood so that Get, Put, etc can be overridden and extended. Thoughts? Quote Link to comment Share on other sites More sharing options...
Jim Kring Posted October 8, 2022 Report Share Posted October 8, 2022 I agree with your points an am very friendly to this recommendation. Would you be willing to collaborate on this effort? It would require writing unit tests, verifying the upgrade process, etc. Update: There's a pull request where @jyoung8711 did just this. I think we should take this step foward. Quote Link to comment Share on other sites More sharing options...
Chris Cilino Posted October 15, 2022 Author Report Share Posted October 15, 2022 Sounds good to me! I tried getting the code but I don't see any changes since Jan 2021 (https://github.com/jyoung8711/JKI-HTTP-REST-Client/tree/jyoung_interface). Am I looking in the wrong place? I was hoping to see the solution so I could evaluate the solution as well. The latest changes I see are updates to the Readme. And the last merge request from jyoung was Jan 2021. AND I'm not the best at git so i'm probably missing the proposed change. Is there a way I could see the pull request that solves the problem I've mentioned? Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.